splitup ChainState type #1731
Draft
splitup ChainState type #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
refactor-Wrapper
branch
2 times, most recently
from
a840931
to
a05054c
Compare
CodSpeed Performance ReportMerging #1731 will improve performances by 10.23%Comparing Summary
Benchmarks breakdown
|
rukai
force-pushed
the
refactor-Wrapper
branch
4 times, most recently
from
f93baab
to
5542f51
Compare
rukai
force-pushed
the
refactor-Wrapper
branch
2 times, most recently
from
ee44e20
to
117fce8
Compare
rukai
force-pushed
the
refactor-Wrapper
branch
from
117fce8
to
42597ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an experiment to see if we could remove the confusing
'shorter/'longerlifetimes from the transform definition.And I think it was a success!
Decoupling the transform iterator from the rest of
ChainStategives us two design improvements:resetmethod from the ChainState,resetis effectively a setup step that occurs after the constructor, which is something to be avoided.One downside is that calling the
call_next_transformmethod is now a little more convoluted as it takes an arg.But I also think this makes it a little clearer what its actually doing.
I'll leave the PR as a draft for a while so I can think it over a bit.